Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holes and Plated Holes are not transferred when converting Circuit JSON to Kicad PCB #4

Open
seveibar opened this issue Sep 20, 2024 · 3 comments
Open

Holes and Plated Holes are not transferred when converting Circuit JSON to Kicad PCB #4

seveibar opened this issue Sep 20, 2024 · 3 comments
Assignees
@seveibar

Comments

@seveibar
Copy link
Contributor

No description provided.

@seveibar seveibar self-assigned this Sep 20, 2024
@seveibar seveibar changed the title Holes are not transferred when converting Circuit JSON to Kicad PCB Holes and Plated Holes are not transferred when converting Circuit JSON to Kicad PCB Sep 20, 2024
@homie-gg homie-gg bot mentioned this issue Sep 20, 2024
Open
@homie-gg homie gg
Copy link

homie-gg bot commented Sep 20, 2024

This might have already been done via: fix: rename pcb_hole.hole_shape "round" to "circle". Add a zod transform to correctly handle old data.

@homie-gg homie gg
Copy link

homie-gg bot commented Sep 20, 2024

This might have already been done via: support for plated holes and holes.

@homie-gg homie gg
Copy link

homie-gg bot commented Sep 20, 2024

Here are some pull requests that might be helpful reference for this task:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seveibar seveibar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seveibar