Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'onReady' of undefined #230

Open
laggingreflex opened this issue Dec 22, 2018 · 1 comment
Open

Cannot read property 'onReady' of undefined #230

laggingreflex opened this issue Dec 22, 2018 · 1 comment

Comments

@laggingreflex
Copy link

laggingreflex commented Dec 22, 2018

Getting this error on Windows, when requiring proxyquire in more than 1 files

Relatively simple reproduction here

Basically:

  • a.js
    require('proxyquire')
  • b.js
    require('proxyquire')
  • index.js
    require('./a')
    require('./b')

Only seems to be happening on Windows (10, build 1809) and Node v11.4. Update: Narrowed down further to exactly 11.4, it still works on 11.3. I'm guessing it's a Node issue, probably introduced in 11.4

Works on Node v9.5, v10.10.

Works also on WSL (node v11.4)

@bendrucker
Copy link
Collaborator

This is probably the place to start looking, no idea why this would be different on Windows:

https://github.com/nodejs/node/blob/321e296371383fd63131d21c1121e22163ddeb86/lib/internal/modules/cjs/loader.js#L628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants