Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable og-image #1473

Open
kamilkisiela opened this issue Apr 16, 2024 · 0 comments
Open

Configurable og-image #1473

kamilkisiela opened this issue Apr 16, 2024 · 0 comments

Comments

@kamilkisiela
Copy link
Member

Instead of hard-coding an og-image based on two properties provided by docs configuration title, websiteName, we should allow to provide a custom url to og-image.

It could be:

interface OgImageProps {
  title: string;
  description?: string;
}

config = {
  ogImage(props: OgImageProps) {
    return '....';
  }
}

We could use it like this:

config = {
   ogImage({title, description}) {
     return `https://.......?product=HIVE&title=${title}&extra={description}`;
   }
}

Why?

No need to pass product (ex value: HIVE) to the configuration and we could also experiment with additional text in the og-image or even completely different og-image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant