Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Battle.net launch strings #19

Open
JamesCJ60 opened this issue Apr 3, 2023 · 5 comments
Open

Broken Battle.net launch strings #19

JamesCJ60 opened this issue Apr 3, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@JamesCJ60
Copy link

Hi, I came across a bug when using .LaunchString with Battle.net games.

With the latest release, it currently returns --game=PRO instead of --exec="launch Pro", etc.

@project-sbc
Copy link

you beat me to this, was going to submit this issue

@project-sbc
Copy link

Additonally.. the demo should account for a battle.net game having battle.net launched. If battle net is not already running that must be started first and fully loaded before running that launch command

@tekgator tekgator self-assigned this Apr 15, 2023
@tekgator tekgator added the bug Something isn't working label Apr 15, 2023
@tekgator
Copy link
Owner

Hi, I came across a bug when using .LaunchString with Battle.net games.

With the latest release, it currently returns --game=PRO instead of --exec="launch Pro", etc.

@JamesCJ60 sounds like an easy bugfix but unfortunately I'm currently traveling. Will have a look when back. If you like feel free to submit a PR.

@tekgator
Copy link
Owner

Additonally.. the demo should account for a battle.net game having battle.net launched. If battle net is not already running that must be started first and fully loaded before running that launch command

I would say I'm not worried about it to much as it is just a DEMO app. This should be of course considered when implementing the library in any app.

@project-sbc
Copy link

project-sbc commented Apr 15, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants