Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Replace E_USER_ERROR with E_USER_NOTICE for non-existing images #166

Open
michael-e opened this issue Feb 28, 2019 · 0 comments
Open

[1.x] Replace E_USER_ERROR with E_USER_NOTICE for non-existing images #166

michael-e opened this issue Feb 28, 2019 · 0 comments

Comments

@michael-e
Copy link
Member

When an image can not be loaded, a E_USER_ERROR is thrown. But Symphony's 404 errors, for example, trigger E_USER_NOTICE exceptions. So the latter should be enough here as well.

This will allow to run big systems with suppressed notices, thus preventing the log file from being polluted with image errors (mainly caused by robots anyway).

I will send a PR to 1.x.
michael-e added a commit to michael-e/jit_image_manipulation that referenced this issue Feb 28, 2019
@michael-e
Throw E_USER_NOTICE instead of E_USER_ERROR
2911aef 
When an image can not be loaded, a E_USER_ERROR is thrown. But Symphony's 404 errors, for example, trigger E_USER_NOTICE exceptions. So the latter should be enough here as well.

This will allow to run big systems with suppressed notices, thus preventing the log file from being polluted with image errors (mainly caused by robots anyway).

Fixes symphonycms#166
@michael-e michael-e mentioned this issue Feb 28, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michael-e