Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache-Control header is faulty #146

Open
michael-e opened this issue Aug 13, 2016 · 2 comments
Open

Cache-Control header is faulty #146

michael-e opened this issue Aug 13, 2016 · 2 comments
Labels
Bug Fixed in integration
Milestone
2.1.0

Comments

@michael-e
Copy link
Member

In the Cache-Control header, JIT separates the max-age= value using a semicolon. This must be a comma.
michael-e added a commit to michael-e/jit_image_manipulation that referenced this issue Aug 13, 2016
@michael-e
Use comma in Cache-Control header; fixes symphonycms#146
6cdbfb1
@michael-e
Copy link
Member Author

PR sent

nitriques pushed a commit that referenced this issue Aug 15, 2016
@michael-e @nitriques
Use comma in Cache-Control header (#147)
1ea6992 
fixes #146
@nitriques nitriques added this to the 2.1.0 milestone Aug 15, 2016
@moretaste
Copy link

Same error is in the 1.x branche

moretaste added a commit to moretaste/jit_image_manipulation that referenced this issue Feb 1, 2017
@moretaste
Use comma in Cache-Control header
09dd890 
Same error as in the 2.x branche: See issue symphonycms#146 symphonycms#146
@moretaste moretaste mentioned this issue Feb 1, 2017
Closed
moretaste added a commit to moretaste/jit_image_manipulation that referenced this issue Feb 8, 2017
@moretaste
Use comma in Cache-Control header
de2ede8 
Same error as in the 2.x branche: See issue symphonycms#146 symphonycms#146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Fixed in integration
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@michael-e @nitriques @moretaste