Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache disabled + external image = no 304 ever #140

Open
nitriques opened this issue Aug 2, 2016 · 1 comment
Open

Cache disabled + external image = no 304 ever #140

nitriques opened this issue Aug 2, 2016 · 1 comment

Comments

@nitriques
Copy link
Member

If you disable the cache, you will never get a 304 on remote image since we (well I) use the temp file's mtime. Is this a problem ? I think we should set the tempfile mtime to the value returned by the server ?

Before 2.0.0, I think it would do the same. Am I right ?

@nitriques nitriques added this to the 2.1.0 milestone Aug 2, 2016
@michael-e
Copy link
Member

First, I verified this with JIT 1.43. When the cache is disabled, you will never get a 304 response (but 200 OK). So with this older JIT version, the issue is the same for external and local images alike!

With JIT 2.x (current integration branch) the issue only exists for external images.

I think we should set the tempfile mtime to the value returned by the server ?

Yes, that sounds like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants