Caching not working with External image, isImageAlreadyCached problem #137
Comments
wdebusschere
changed the title
|
Which version of Symphony ? And jit ? I have a black image (which is a problem) but not the same as yours... |
|
Symphony 2.6.7 |
|
Hum... ok thanks. Still can't reproduce but still having a black image from cache |
|
I've boiled it down to transparent png, which gets their transparency ripped out when the file is save from cache, but I do not know how this happens... |
The way we handled HEAD request was 1. Different from the GET request, since it lacked some checks 2. Way to general for our needs This commit refactors the old things with a single brand new function that will 1. Make sure the request is a 200 2. Return only cache related headers, since that's the goal Re #136 Cc #138 Cc #130 Cc #137
This commit cleans up the code and fixes a bunch of issues. * Cache validation There was a bug, #137, which would made the cache unusable with external images. This has been fixed. The function also makes sure to validate that the original file, either remote or local, has not changed since the last modification of the cache file itself. If the cache file is no longer valid, it gets deleted. This also fixes #136. * Last modified value There was a problem describe in #138 where a second request to a url with proper cache heading would still send a 200, because the Last-Modified value was read from a different source. This commit changes this by doing the following. 1. Always use a local mtime: either the original local file or our tempfile created from the http request. 2. If cache is enabled, always use the cache file mtime, even when the request creates the cache file. This insure repeatable results for all subsequent requests. This brings a side effect that is needed: before, we used to touch the cache file when found valid and we must need to stop this to be able to get repeatable results. --- Throughout the process, values are "exported" into the parameter array when certain condition are met. This insure that the values sent to the user will be the right one. Sorry for the big commit, I did my best to split things up :) Fixes #137 Fixes #136 Fixes #138
|
@wdebusschere Latest integration code should fix this. If you could confirm, that would be neat! |
|
@wdebusschere Lots of work has been made yet again, if you could confirm please. Thanks (but no rush) |
|
Perfect. + no more errors in the Symphony log
|
|
SUPER! Thanks! |
Warning: GenericErrorHandler 2: filemtime(): stat failed for /Users/xxx/Sites/www.domain.com/workspace/hosting26.externalserverxxx.com/pictures/folders/2825AL.jpg on line 121 of file /Users/xxx/Sites/www.domain.com/extensions/jit_image_manipulation/lib/class.jit.php
Throws this error with function isImageAlreadyCached
$parameters['last_modified'] = @filemtime(WORKSPACE . '/'. $parameters['image']);
The text was updated successfully, but these errors were encountered: