Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong handles: & becomes and-amp #30

Open
mprofitlich opened this issue Sep 30, 2018 · 4 comments
Open

Wrong handles: & becomes and-amp #30

mprofitlich opened this issue Sep 30, 2018 · 4 comments
Labels

Comments

@mprofitlich
Copy link

Associated entry handles with an ampersand turn into and-amp. This happens both in standard English installations and installations in another language (in my case German).

Example
Section 1: Text field. Entry: Bread & Butter
Section 2: Association to section 1's textfield
Data source: Section 2: association
XML: bread-and-amp-butter.

Symphony 2.7.7
Association field 2.1.0

@nitriques
Copy link
Member

What's the handle for Text field in Section 1 ? Is it ok ?

@mprofitlich
Copy link
Author

Yes, it is ok.
XML

@nitriques
Copy link
Member

@jonmisfud any ideas ? Would it be related to this: https://github.com/symphonists/association_field/blob/master/fields/field.association.php#L385 ?

@twiro
Copy link
Member

twiro commented Oct 26, 2018

I just updated an older symphony project and faced exactly the same problem!

I also tested the datasource-output of associated items in other installations to backtrace where this behavior comes from and it looks like it's happening since Symphony 2.6.X, no matter which version of association field is used…

Symphony Version Association Field Version "&" in handle Status
2.5.2 1.0.0.beta x-and-y
2.6.2 1.3.3 x-and-amp-y
2.6.3 1.0.0.beta x-and-amp-y
2.6.3 1.0.1 x-and-amp-y
2.6.7 1.0.1 x-and-amp-y
2.7.7 2.1.0 x-and-amp-y

Haven't tested if it affects datasource filtering too, but it can definitively cause troubles in the templates if you use the associated item-handles for further handle-based features/routing/etc.

Will try to do some further investigations as soon as I find the time, but for now I'll just leave this information here.

@twiro twiro added the bug label Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants