Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Do not use plainAuth when no user or password #3320

Open
yonas opened this issue Sep 19, 2024 · 0 comments · May be fixed by #3321
Open

[bug] Do not use plainAuth when no user or password #3320

yonas opened this issue Sep 19, 2024 · 0 comments · May be fixed by #3321
Labels
bug Something isn't working

Comments

@yonas
Copy link

yonas commented Sep 19, 2024

Describe the bug with a clear and concise description of what the bug is.

Do not use plainAuth when no user or password.

What's your GoToSocial Version?

0.16.0

GoToSocial Arch

No response

What happened?

See https://gitlab.com/commento/commento/-/merge_requests/113/diffs

Since golang/go@701fa1c
golang fails when using plainAuth on a non TLS connection, which is not desirable when using no authentication at all.

What you expected to happen?

No response

How to reproduce it?

No response

Anything else we need to know?

No response
@yonas yonas added the bug Something isn't working label Sep 19, 2024
yonas added a commit to yonasBSD/gotosocial that referenced this issue Sep 19, 2024
@yonas
Do not use plainAuth when no user or password. Fixes superseriousbusi…
b0bcc1d 
…ness#3320
@yonas yonas linked a pull request Sep 19, 2024 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not use plainAuth when no user or password. Fixes #3320 yonasBSD/gotosocial
1 participant
@yonas