Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DockerBuilder): make ADD and COPY behaviour consistent with Docker #32

Open
nokome opened this issue Oct 25, 2018 · 0 comments
Open

feat(DockerBuilder): make ADD and COPY behaviour consistent with Docker #32

nokome opened this issue Oct 25, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@nokome
Copy link
Member

nokome commented Oct 25, 2018

We support both ADD and COPY in the # dockter section of a Dockerfile

https://github.com/stencila/dockter/blob/v0.2.6/src/DockerBuilder.ts#L167

Docker's ADD and COPY instructions are very similar but COPY is generally recommended. Nonetheless, if we support ADD in the # dockter section of a Dockerfile then we should provide consistent behaviour.
@nokome nokome added the enhancement New feature or request label Oct 25, 2018
@nokome nokome added this to the 1.x milestone Nov 12, 2018
@nokome nokome removed this from the 1.1 milestone Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nokome