-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WC] Add countdown pill to sign dialogs #16314
Comments
@alexjba do we already have the corresponding notification in place? Should the little timer component be covered here, or in separate ticket? That said, I'm not totally convinced the timer itself should be part of the countdown pill here, wdyt? |
We don't have the notification. Not totally convinced either. Maybe it would be nice to have the visual component as a base class and the timer logic in the upper component. Just in case we find different use cases for it. |
- show countdown until which the sign (WalletConnect and Swap) dialogs expire - after expiration, hide the Reject/Sign buttons and display a plain Close button - make the dialogs non-closable by clicking outside or pressing Esc; the user has to explicitely click some of the footer buttons Fixes #16327 Fixes #16314
- show countdown until which the sign (WalletConnect and Swap) dialogs expire - after expiration, hide the Reject/Sign buttons and display a plain Close button - make the dialogs non-closable by clicking outside or pressing Esc; the user has to explicitely click some of the footer buttons Fixes #16327 Fixes #16314
- show countdown until which the sign (WalletConnect and Swap) dialogs expire - after expiration, hide the Reject/Sign buttons and display a plain Close button - make the dialogs non-closable by clicking outside or pressing Esc; the user has to explicitely click some of the footer buttons Fixes #16327 Fixes #16314
Add the countdown pill
Figma
Spec here: WalletConnect/walletconnect-monorepo#1851
The text was updated successfully, but these errors were encountered: