tools: added title/desc checks to split.py #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EaterOA
requested changes
Jul 12, 2024
| @@ -134,6 +157,11 @@ def main(): | |||
| talk_path = os.path.join(subdir_path, talk_name) | |||
| thumbnail_path = os.path.join(subdir_path, image_name) | |||
|
|
|||
| youtube_desc = make_video_description(talk, talk["description"]) | |||
There was a problem hiding this comment.
I think these should be done further up all at once prior to downloading / cutting any video. With potentially long-processing scripts, as much validation should be done upfront as possible, instead of potentially having the user come back from dinner to see that it threw an exception after processing one video.
I'm not sure if it'll be used, but this also makes it cleaner to offer a cmdline arg to not do this validation, say if the user really doesn't care about fixing descriptions right now. Letting the validation in upload.py stay is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61 Added the title and description length/character checks to
split.pyso it sends a warning message when the script is run.I looked into adding the checks when we get the JSON, but couldn't find a good way since we use a curl command to do so. I've kept the title/desc checks in
upload.py, but let me know if we should delete them there and only have them insplit.py.