-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection caching like in the python driver #486
Comments
also tracked in |
any progress on this? |
#661 should implement this if i'm correct; which is released with 1.6.15
(currently we're at 1.6.16) |
Hey, thanks for the reply 🙌 I just bumped Running a |
hi @larspettermadsstuen so for the ODBC, JDBC, and Python connectors for this feature to work , one needs to also enable it on the Snowflake side (documentation: Using Connection Caching to Minimize the Number of Prompts for Authentication)
and see if it reduces the browser popups now? if it's still an issue, we'll look into it. |
Hi, In any case, this occurs via the snowflake terraform provider, which doesn't use either of the mentioned connectors (?) |
no, the provider uses the gosnowflake connector under the hood. we'll take a look what might be wrong with the connection caching behaviour even after 1.6.15, or what am I missing. Thank you for bearing with us while this is investigated! |
👋 Checking in again - wondering if there has been any progress on this issue? |
apparently i missed an update here - apologies ! connection/mfa caching for the gosnowflake connector has been implemented with #705 couple of weeks ago, and released with 1.6.17 this resolves the issue from the standpoint of the gosnowflake connector - however for it to take effect in the terraform provider too, i see 2 steps necessary
but from the perspective of this library, the capability to enable (with 1.6.17) an disable (with upcoming next release) the feature is already there / will be shortly there. |
Thank you! |
closing as it has been released with v1.6.17 |
I don't think the latest version of the provider has been rebased on the v1.6.17 of gosnowflake, is there any workaround I can do at the moment? |
this is the gosnowflake driver's repository, and the above comment seems to be about the snowflake terraform provider, so i feel it being in a little inappropriate place ;) anyways, snowflake terraform provider versions 0.58.1 and up already based on gosnowflake 1.6.17+ . but there seems to be an issue still, which you can follow at Snowflake-Labs/terraform-provider-snowflake#1700 workaround is not to use externalbrowser authentication i'm afraid, but e.g. keypair instead. but i still feel the snowflake terraform provider related discussions should be kept at the appropriate repo if that's possible |
Issue description
Hi Team,
We use the terraform snowflake provider implemented by CZI and it's pretty much unusable with
browser_auth
due to everyterraform plan
andterraform apply
creating a new browser tab for authentication.This issue is due to the underlying dependency on the gosnowflake module which doesn't cache a connection.
It would be great if we could implement connection caching using secure-local-storage as implemented in the python connector?
This allow the snowflake terraform provider to use this module without opening 100s of tabs when doing
CRUD
for 100s of resources.The text was updated successfully, but these errors were encountered: