From 4c7e0cfe6cca0c9c0b0d5b454302ece0bf73809b Mon Sep 17 00:00:00 2001
From: Rob Allen <rob@akrabat.com>
Date: Thu, 23 Nov 2023 12:45:08 +0000
Subject: [PATCH] Update BodyParsingMiddlewareTest

Dynamically adding a property to a class is deprecated and so rather
than adding the request to the response from the handler, we now add it
to the handler itself and test it there.
---
 tests/Middleware/BodyParsingMiddlewareTest.php | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tests/Middleware/BodyParsingMiddlewareTest.php b/tests/Middleware/BodyParsingMiddlewareTest.php
index 75f0df3c4..30cba022c 100644
--- a/tests/Middleware/BodyParsingMiddlewareTest.php
+++ b/tests/Middleware/BodyParsingMiddlewareTest.php
@@ -31,6 +31,7 @@ protected function createRequestHandler(): RequestHandlerInterface
         $response = $this->createResponse();
         return new class ($response) implements RequestHandlerInterface {
             private $response;
+            public $request;
 
             public function __construct(ResponseInterface $response)
             {
@@ -39,7 +40,7 @@ public function __construct(ResponseInterface $response)
 
             public function handle(ServerRequestInterface $request): ResponseInterface
             {
-                $this->response->request = $request;
+                $this->request = $request;
                 return $this->response;
             }
         };
@@ -152,9 +153,10 @@ public function testParsing($contentType, $body, $expected)
         $request = $this->createRequestWithBody($contentType, $body);
 
         $middleware = new BodyParsingMiddleware();
-        $response = $middleware->process($request, $this->createRequestHandler());
+        $requestHandler = $this->createRequestHandler();
+        $middleware->process($request, $requestHandler);
 
-        $this->assertEquals($expected, $response->request->getParsedBody());
+        $this->assertEquals($expected, $requestHandler->request->getParsedBody());
     }
 
     public function testParsingWithARegisteredParser()
@@ -167,9 +169,10 @@ public function testParsingWithARegisteredParser()
             },
         ];
         $middleware = new BodyParsingMiddleware($parsers);
-        $response = $middleware->process($request, $this->createRequestHandler());
+        $requestHandler = $this->createRequestHandler();
+        $middleware->process($request, $requestHandler);
 
-        $this->assertSame(['data' => '{"foo":"bar"}'], $response->request->getParsedBody());
+        $this->assertSame(['data' => '{"foo":"bar"}'], $requestHandler->request->getParsedBody());
     }
 
     public function testParsingFailsWhenAnInvalidTypeIsReturned()