Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access_type for Google #16

Open
cabrilo opened this issue Aug 6, 2014 · 0 comments
Open

access_type for Google #16

cabrilo opened this issue Aug 6, 2014 · 0 comments

Comments

@cabrilo
Copy link

cabrilo commented Aug 6, 2014

Hello,

First of all, thank you for this great library, I really love its approach and how its written.

I have one issue though: I would like to be able to customize access_type when accessing Google Oauth2. As a matter of fact, I think it would be nice to be able to set values for all custom parameters that Google offers, e.g. access_type, approval_prompt, login_hint, etc. You can see the list here.

I'd be happy to create a pull request for this, but what would be the best way to do it? E.g. create ClientOptions->setUrlParameters(array('access_type' => 'offline', 'approval_prompt' => 'force')), or define setters and getters on \ReverseOAuth2\Client\Google like Google->setAccessType('offline'), or something completely different?

Thanks again,
Dejan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant