You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed version 7.17.0 added @storybook/preview-api to shipped dependencies. I grepped the whole shipped javascript code and did not find any references to storybook — that means it should be in devDependencies instead. (removing it from dependencies and running electron-builder again seems to shave about 3MB unpacked)
This is not the first time a node module has been incorrectly marked as a runtime dependency. At openSUSE, we have determined the following ones are trivially safe to remove (because they're not referenced by anything):
Hi @brjsp thanks for letting us know. You are correct that @storybook/preview-api should be a dev-only dependency. Sorry for the mistake and we will fix it!
I noticed version 7.17.0 added
@storybook/preview-api
to shipped dependencies. I grepped the whole shipped javascript code and did not find any references to storybook — that means it should be in devDependencies instead. (removing it from dependencies and running electron-builder again seems to shave about 3MB unpacked)This is not the first time a node module has been incorrectly marked as a runtime dependency. At openSUSE, we have determined the following ones are trivially safe to remove (because they're not referenced by anything):
The text was updated successfully, but these errors were encountered: