Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APK update post-installation notification wrongly claims the update was automatic #13700

Open
4 tasks done
rustybird opened this issue Sep 19, 2024 · 1 comment
Open
4 tasks done

Comments

@rustybird
Copy link


Bug description

The website distribution build's update post-installation notification says You were automatically updated to version (...). But except for nightlies, APK updates aren't automatic:

// TODO Auto-updates temporarily restricted to nightlies. Once we have designs for allowing users to opt-out of auto-updates, we can re-enable this
return Environment.IS_NIGHTLY && Build.VERSION.SDK_INT >= 31 && SignalStore.apkUpdate.autoUpdate && !AppForegroundObserver.isForegrounded()

Steps to reproduce

  • Update Signal by tapping the update notification

Actual result: NotificationYou were automatically updated to version (...)
Expected result: Notification You were updated to version (...)

Device info

Android version: GrapheneOS 2024090400
Signal version: 7.17.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants
@rustybird and others