New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move default-route logic to server-router #101

Open

yoshuawuyts opened this issue Jun 28, 2017 · 1 comment

Collaborator

yoshuawuyts commented Jun 28, 2017

The custom logic here is a bit hairy, we should move it to https://github.com/yoshuawuyts/server-router and move semver major on it. Would be a patch release here tho

Collaborator Author

yoshuawuyts commented Jun 29, 2017

Oh, @timwis pointed out yesterday that we could also just use:

app.route('GET', '*', cb)

Which would catch all routes as a default. Can remove the default clause from both this and server-router I reckon. Yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment