Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox findDOMNode is deprecated in StrictMode #3013

Open
dlferro opened this issue Mar 3, 2022 · 2 comments
Open

Combobox findDOMNode is deprecated in StrictMode #3013

dlferro opened this issue Mar 3, 2022 · 2 comments

Comments

@dlferro
Copy link
Contributor

dlferro commented Mar 3, 2022

I've run into this warning using the combobox with React 17. It appears that it was tackled previously with popovers. @interactivellama is the gist of this issue just replacing it with components reference? I'm assuming in this instance it's a utility or sub component of comobox.

@pmartin35
Copy link
Contributor

Also running into this

@interactivellama
Copy link
Contributor

interactivellama commented Jun 7, 2022

This is likely an issue found in the https://github.com/salesforce/design-system-react/blob/master/utilities/keyboard-navigate.js and https://github.com/salesforce/design-system-react/blob/master/utilities/keyboard-navigable-dialog.js which calls findDOMNode to check for event target.

yes, it likely can be updated to compare refs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants