Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 403 Forbidden in Build ruby.wasm Github Actions Workflow #512

Closed
wants to merge 2 commits into from

Conversation

mashallah
Copy link

@mashallah mashallah commented Aug 21, 2024

Fixes #513 by:

  • upgrading docker/build-push-action from v5 to v6
  • adding required permissions to the build-builder-image step

@mashallah mashallah changed the title upgrade build workflow to docker/build-push-action@v6 Fix 403 Forbidden in Build ruby.wasm Github Actions Workflow Aug 21, 2024
@mashallah mashallah marked this pull request as ready for review August 21, 2024 21:01
@mashallah
Copy link
Author

mashallah commented Aug 22, 2024

@kateinoigakukun please review, I hope this helps! 🙂

@kateinoigakukun
Copy link
Member

Granting a new write permission should not be necessary as long as changes on the main branch are push by people having write permission. Dependabot is the exception but I don't want to add a new potential security concern just for this.
And also we intentionally use v5 docker action acd7824

Closing for these reasons but thank you for your contribution.

rhee876527 added a commit to rhee876527/simulate-busy that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent 403 Forbidden error in the Build ruby.wasm Github Actions workflow
2 participants