Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tinypng extension #14552

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update tinypng extension #14552

wants to merge 5 commits into from
+2,451 −4,111

Conversation

j3lte
Copy link
Contributor

@j3lte j3lte commented Sep 19, 2024 •
edited
Loading

Description

  • Make the method in Resizing Images a Dropdown instead of a Text Field
  • Fix the resize method for scale, where width and height are not both required
  • In case a user sets the Destination Folder Path to the same folder, but doesn't enable Overwrite Original Image File, add .compressed or .resized to the file name to avoid overwriting the original file
  • Update dependencies

Screencast

Checklist

@j3lte
Update tinypng extension
508872e 
- Extension update
- Initial commit
@raycastbot raycastbot added the extension fix / improvement Label for PRs with extension's fix improvements label Sep 19, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Sep 19, 2024 •
edited
Loading

Thank you for your contribution! 🎉

🔔 @kawamataryo you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@raycastbot raycastbot added the extension: tinypng Issues related to the tinypng extension label Sep 19, 2024
@j3lte j3lte marked this pull request as draft September 19, 2024 12:22
@j3lte
Copy link
Contributor Author

j3lte commented Sep 19, 2024

Note: Getting an error when resizing, figuring that one out before setting it to ready to be reviewed...

@j3lte j3lte marked this pull request as ready for review September 19, 2024 12:30
@j3lte
Copy link
Contributor Author

j3lte commented Sep 19, 2024

@kawamataryo the PR is ready for review now, had to also fix a bug in the scaling command 😄

@kawamataryo
Copy link
Contributor

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: tinypng Issues related to the tinypng extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j3lte @raycastbot @kawamataryo