Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcefully follow import to site-package, despite no py.typed file #8421

Closed
sebastian-philipp opened this issue Feb 20, 2020 · 2 comments
Closed

Comments

@sebastian-philipp
Copy link

If I manually do a

touch .tox/mypy/lib/python3.6/site-packages/kubernetes/py.typed

I can

  1. increase my testing coverage and
  2. remove mypy's
    [mypy-kubernetes.*]
    ignore_missing_imports=True

I'm missing a way to force following the import to kubernetes.

Right now, my super ugly workaround in tox is:

[testenv:mypy]
basepython = python3
deps =
    -r requirements.txt
    mypy
whitelist_externals = touch
commands = touch {envsitepackagesdir}/kubernetes/py.typed
           mypy --config-file=../../mypy.ini \
             -m ... \
@Vozf
Copy link

Vozf commented Nov 7, 2020

Are there any plans for this? This seems like a super useful feature. There are a lot of packages which have type annotations but forget\don't know about py.typed. Now I need to create a pr to each of those packages, but this is not actually necessary as they already have type annotations, there is only py.typed missing.
This feature doesn't seem complex but can be very useful

@ethanhs
Copy link
Collaborator

ethanhs commented Nov 7, 2020

Oh this is a duplicate of #8545. I think there seems to be some desire for this feature so I think I will look over the PR related to that issue.

@ethanhs ethanhs closed this as completed Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants