Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the bank module to track the value owners of scopes. #2137

Open
4 tasks
SpicyLemon opened this issue Aug 26, 2024 · 1 comment · May be fixed by #2140
Open
4 tasks

Use the bank module to track the value owners of scopes. #2137

SpicyLemon opened this issue Aug 26, 2024 · 1 comment · May be fixed by #2140
Assignees
Labels
bank Bank Module metadata Metadata Module
Milestone

Comments

@SpicyLemon
Copy link
Contributor

Summary

Use the bank module to keep track of the value owner of a scope.

Problem Definition

Scopes have to be read and written in order to update the value owners which causes a lot of unneeded read/writes. There are several operations that only update the value owner, though, that could be made much cheaper by extracting the value owner into its own record. Further, things like quarantine and sanction should apply to scope value owners too.

Proposal

Use the bank module to record the value owner of scopes by giving each the denom "nft/", e.g. nft/scope1qzge0zaztu65tx5x5llv5xc9ztsqxlkwel.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller
Copy link
Member

Drawbacks:

  • More complex metadata module since it'll now be using/managing bank state too.

This would be a reason to not convert existing endpoints to their bank managed counter parts... I guess that still doesn't let us simplify this away though because creating a scope means minting the token with the bank module as well...

@SpicyLemon SpicyLemon linked a pull request Aug 29, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bank Bank Module metadata Metadata Module
Projects
Development

Successfully merging a pull request may close this issue.

2 participants