Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize some of the consensus timing config fields. #2121

Open
4 tasks
SpicyLemon opened this issue Aug 12, 2024 · 0 comments
Open
4 tasks

Centralize some of the consensus timing config fields. #2121

SpicyLemon opened this issue Aug 12, 2024 · 0 comments
Milestone

Comments

@SpicyLemon
Copy link
Contributor

Summary

There's several consensus timing fields in the config file (in config.toml) that we'd like to standardize across nodes.

Problem Definition

We see a lot of sporadic block times and it's possibly related to various consensus. settings which each node can define for itself.

Proposal

There's a couple things we can do depending on how much effort we want to put in.

  1. (low effort) Hard-code the values in our config management stuff. This will involve providing the hard-coded values to viper.
  2. (more effort) Create some new params to hold them and store them somewhere. Set them in the next upgrade, and provide endpoints for getting and setting-via-gov-prop.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@SpicyLemon SpicyLemon added this to the v1.20.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant