Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module_query_safe to appropriate queries #2005

Open
4 tasks
Taztingo opened this issue May 24, 2024 · 0 comments
Open
4 tasks

Add module_query_safe to appropriate queries #2005

Taztingo opened this issue May 24, 2024 · 0 comments
Milestone

Comments

@Taztingo
Copy link
Contributor

Summary

None of our deterministic queries have been marked with option (cosmos.query.v1.module_query_safe) = true;. This means that we cannot take full advantage of them and allow them to be used by the internal state machine.

Problem Definition

This prevents new features in cosmos-sdk from correctly using our chain, and it allows informs devs which queries they can safely use.

Proposal

  1. Find all queries that are classified as safe. They have the following attributes:
  • The query tracks gas usage.
  • The query has a deterministic response.
  1. Add option (cosmos.query.v1.module_query_safe) = true; to each query that we classify as safe.
  2. Regenerate protos.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@SpicyLemon SpicyLemon added this to the v1.20.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants