Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBS attempts to build execution plan for hooks from disabled modules #3748

Open
linux019 opened this issue Jun 12, 2024 · 2 comments
Open

PBS attempts to build execution plan for hooks from disabled modules #3748

linux019 opened this issue Jun 12, 2024 · 2 comments

Comments

@linux019
Copy link
Contributor

linux019 commented Jun 12, 2024

For testing purposes sometimes need to quickly disable or enable module. But when module is disabled PBS logs a
lot of warnings "Not found hook while building hook execution plan..." To supress this warning it needs to comment out all lines related to module in all hook sequences

hooks:
  enabled: true
  modules:
    vendor:
      module1:
         enabled: false

  host_execution_plan:
    endpoints:
      "/openrtb2/auction":
        stages:
          entrypoint:
            groups:
              timeout: 100 #ms
              hook_sequence:
                 - module_code: "vendor.module1"
                   hook_impl_code: "vendor.module1"
@bsardo bsardo added the PBS-Go label Jun 12, 2024
@bretg bretg added the bug label Jun 28, 2024
@justadreamer
Copy link
Contributor

justadreamer commented Jul 12, 2024

Hi @linux019 tried to reproduce - I don't get these warnings in the console when module is disabled, but still mentioned in the hook_execution_plan. I am running the go run main.go as normal and then send some test requests - no warnings are logged. Where exactly do you see these warnings and is it reproduced with any of the current modules? Thanks

@linux019
Copy link
Contributor Author

hooks:
  enabled: true
  modules:
    prebid:
      ortb2blocking:
        enabled: false

  host_execution_plan:
    endpoints:
      "/openrtb2/auction":
        stages:
          entrypoint:
            groups:
              timeout: 100 #ms
              hook_sequence:
          bidder_request:
            groups:
              timeout: 100 #ms
              hook_sequence:
               - module_code: "prebid.ortb2blocking"
                 hook_impl_code: "prebid.ortb2blocking"
          raw_bidder_response:
            groups:
              timeout: 50
              hook_sequence:
                - module_code: "prebid.ortb2blocking"
                  hook_impl_code: "prebid.ortb2blocking"

On startup PBS logs message that module is disabled

I0725 10:22:55.102247   54942 modules.go:74] Skip prebid.ortb2blocking module, disabled.

Start the server with arguments -alsologtostderr -stderrthreshold=INFO

Send an auction request to "/openrtb2/auction"

W0725 10:24:38.585047   55258 plan.go:201] Not found hook while building hook execution plan: prebid.ortb2blocking prebid.ortb2blocking
W0725 10:24:38.585157   55258 plan.go:201] Not found hook while building hook execution plan: prebid.ortb2blocking prebid.ortb2blocking

@linux019 linux019 changed the title PBS attempts to execute hooks from disabled modules PBS attempts to build execution plan for hooks from disabled modules Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Dev
Development

No branches or pull requests

4 participants