Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start script support #192

Open
jvail opened this issue Nov 23, 2021 · 2 comments
Open

start script support #192

jvail opened this issue Nov 23, 2021 · 2 comments

Comments

@jvail
Copy link

jvail commented Nov 23, 2021

It seems adding the start script mentioned here has no effect in plasma. I guess because there is a custom tljh_plasma/entrypoint/entrypoint.sh script.
I did change the file and added source ./start here

cd ${IMAGE_DIR}
# execute the notebook process as the given user
exec su - $NB_USER -m -c '"$0" "$@"' -- "$@"

Did I miss something or is there a proper way to execute the start script. If not maybe it is possible to add a line to entrypoint.sh?

Thank you
Jan

@jtpio
Copy link
Member

jtpio commented Dec 2, 2021

Thanks @jvail for reporting.

I believe this is right. The tljh-plasma plugin uses a custom entrypoint to be able to start the servers as the users on the host machine. Maybe it should try to execute the start script if it exists, and default to the current exec command otherwise?

@jvail
Copy link
Author

jvail commented Dec 2, 2021

Thanks for looking into this issue. I am afraid, I am neither a docker nor a jupyter hub pro. But the little 'hack' into the entrypoint.sh did work for us - but I am not sure if it is the best option to enable the start script. I thought it might be a good idea to make the start script available by default in plasma.

The use case was to run a pip install -e . in order to install a lib in dev mode from within the repo every time the server starts for a specific user. Because otherwise the dev install will live in home/jovyan and wont reflect any changes made after the image is built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants