You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When testing with mxw/vim-jsx and pangloss/vim-javascript the line with the jsx comment is labelled a jsxChild. Combined with othree/yajs.vim (which has way nicer highlighting 👏 ) the line becomes javaScriptBraces. This means my context aware commenting plugin adds {/* */}, but upon requesting to uncomment does nothing, or worse, when requesting to toggle the comment, comments again, making it // {/* */} as it 'correctly' recognized the JavaScript syntax was not yet commented as {/* */} is only a comment in JSX.
I know parsing JSX is a pain in the butt, let me know if there's anything else I can do to help. Commenting I'm noticing is quite frequently used in UI work.
Thanks for an awesome plugin 🙏 .
The text was updated successfully, but these errors were encountered:
In the following code:
When testing with
mxw/vim-jsx
andpangloss/vim-javascript
the line with the jsx comment is labelled ajsxChild
. Combined withothree/yajs.vim
(which has way nicer highlighting 👏 ) the line becomesjavaScriptBraces
. This means my context aware commenting plugin adds{/* */}
, but upon requesting to uncomment does nothing, or worse, when requesting to toggle the comment, comments again, making it// {/* */}
as it 'correctly' recognized the JavaScript syntax was not yet commented as{/* */}
is only a comment in JSX.Related issue tomtom/tcomment_vim#248 in tcomment that has some screenshots.
I know parsing JSX is a pain in the butt, let me know if there's anything else I can do to help. Commenting I'm noticing is quite frequently used in UI work.
Thanks for an awesome plugin 🙏 .
The text was updated successfully, but these errors were encountered: