Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Ruby 2.3 #52

Open
ota42y opened this issue Oct 5, 2019 · 1 comment
Open

Disable Ruby 2.3 #52

ota42y opened this issue Oct 5, 2019 · 1 comment
Milestone
1.0.0

Comments

@ota42y
Copy link
Owner

ota42y commented Oct 5, 2019

Ruby 2.3 is already EOL.
So I'm going to drop ruby 2.3 support.

I think when committee drop ruby 2.3 support or we have a very difficult problem, we will drop support.
@ota42y
Copy link
Owner Author

ota42y commented Oct 5, 2019

https://github.com/ota42y/openapi_parser/pull/51/files#diff-b88c8907571865f9d8cbdcb0a78c051eR71
This change use match? method, it not support ruby 2.3 (ruby 2.4 or later)
But we can use other way to support ruby 2.3 so we dosen't drop support.

When we drop ruby 2.3 fix it.

ota42y added a commit that referenced this issue Oct 5, 2019
@ota42y
use match method
4665038 
match? method is good performance but it added ruby 2.4.
So we don't use ruby 2.3.

When we drop ruby 2.3 support, we should fix it
#52
@ota42y ota42y mentioned this issue Oct 5, 2019
Merged
@ota42y ota42y added this to the 1.0.0 milestone May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@ota42y