Empty response body fails validation

[klausbadelt]

Validation fails on 204 response, which has empty string as body.

Example:

paths:
  /health_check:
    get:
      description: Health check
      responses:
        '204':
          description: OK

Code

OpenAPIParser.load 'openapi.yml'
request_operation = root.request_operation :get, '/health_check'
validatable_response_body = OpenAPIParser::RequestOperation::ValidatableResponseBody.new(204, "", {})
response_validate_options = OpenAPIParser::SchemaValidator::ResponseValidateOptions.new
request_operation.validate_response_body(validatable_response_body, response_validate_options)

Expected result is truth-y, but actual result is nil.

This is btw similar to a bug in openapi-library/OpenAPIValidators#54.

[ota42y]

• This gem raise error when validation is failed.
• This gem return nil when validation passed.
  • In this case, we can't find media type object so don't validate parameter and return nil

  • openapi_parser/lib/openapi_parser/schemas/response.rb

    Line 26 in 9c7a802

    return nil

But I think it is better to return true when the validation was passed so we should change return value :)