Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path Excludes not working when workspaces are introduced in the code repository based on NPM, PNPM, Yarn2 #8940

Open
porsche-rishisaxena opened this issue Jul 26, 2024 · 3 comments
Labels
analyzer About the analyzer tool bug Issues that are considered to be bugs

Comments

@porsche-rishisaxena
Copy link

porsche-rishisaxena commented Jul 26, 2024

Describe the bug

Path Excludes not working when workspaces are introduced in the code repository based on NPM, PNPM, Yarn2.

To Reproduce

Steps to reproduce the behavior:

  1. Sample Code Repo created to reproduce the behavior: https://github.com/porsche-ozgursedefoglu/npm-workspaces
  2. skip_excluded: true configured in .ort.yml. Please refer to https://github.com/porsche-ozgursedefoglu/npm-workspaces/blob/main/.ort.yml
  3. Run the analyzer on the above repo
    docker run -v $PWD:/project
    ort:latest
    -P ort.analyzer.allowDynamicVersions=true --debug analyze
    -i /project/
    -o /project/ort/

Expected behavior

After Path Exclude applied in .ort.yml, the paths are still visible in the reports which should not be the case and the below statement is violated:
"ORT can be configured to skip them completely during the analysis phase. The affected elements are then not processed any further and do not occur in generated reports."

@porsche-rishisaxena porsche-rishisaxena added bug Issues that are considered to be bugs to triage Issues that need triaging labels Jul 26, 2024
@fviernau
Copy link
Member

"ORT can be configured to skip them completely during the analysis phase. The affected elements are then not processed any further and do not occur in generated reports."

@porsche-rishisaxena have you configured ORT to do so? (If yes, this could be added to the reproduce step after #1.)

@porsche-ozgursedefoglu
Copy link

@fviernau we did this step in our .ort.yml file which you can see in the sample code repository as following;
analyzer:
skip_excluded: true

@porsche-rishisaxena
Copy link
Author

@fviernau I have added the second step in the problem statement description what @porsche-ozgursedefoglu mentioned where we use skip_excluded: true. Please refer to the sample repo we created for reproducing: https://github.com/porsche-ozgursedefoglu/npm-workspaces/blob/main/.ort.yml

@sschuberth sschuberth added analyzer About the analyzer tool and removed to triage Issues that need triaging labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer About the analyzer tool bug Issues that are considered to be bugs
Projects
None yet
Development

No branches or pull requests

4 participants