Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touring style: Cycle paths in night mode hardly visible #20872

Open
scaidermern opened this issue Sep 18, 2024 · 10 comments
Open

Touring style: Cycle paths in night mode hardly visible #20872

scaidermern opened this issue Sep 18, 2024 · 10 comments
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning

Comments

@scaidermern
Copy link
Contributor

scaidermern commented Sep 18, 2024

Description

Touring style in night mode: OsmAnd style in night mode:

Your Environment (required)

OsmAnd Version: 4.8.6
@sonora
Copy link
Member

sonora commented Sep 19, 2024

I'm not sure what a good solution is. The contrast used in Touring view is consistent with that of other tracks across most map situations. Choosing a brighter color creates contrast issues in frequent situations where cycle tracks lead along highways, compare these screenshots of Touring View vs. OsmAnd.

3 2

Overall, I am not sure how much priority should be really given to cycle paths in night view. Probably, they should definitely not outshine other routes more regularly viewed and used with a night view?

@scaidermern
Copy link
Contributor Author

Overall, I am not sure how much priority should be really given to cycle paths in night view.

With the bicycle profile being enabled, they should get a high priority I guess. The styles are profile-aware, aren't they?

@scaidermern
Copy link
Contributor Author

But maybe it's just my phone's display that is currently dying 😕

@sonora
Copy link
Member

sonora commented Sep 19, 2024

Let me know if it's a real showstopper for you also on a new device. I hardly have a use case for the bicycle profile in night mode... 😉 Also: We need to look at the situation at night. What seems as too low contrast in daylight is sometimes the right contrast in darkness.

Yes, you can make features of a map style profile-dependent. I have always kept this to a minimum, as it complicates the code, all testing, and the user perception of what's going on if too many things like colors not only change between day/night but also between profiles...

Probably there is some middle ground in lighting the cyclepath/cycleway/etc. color some for the bike profile at night, but not too much to create the effect I demonstrate above. Main effort after coding is finding/testing the right nuance. And surprisingly, things have been like this for some 10 years now, never drew any feedback so far ... (but not saying you are wrong 😉)

@scaidermern
Copy link
Contributor Author

I'll check again when I have a replacement device. Will probably take about two weeks since I'm currently on vacation 🙂

@sonora
Copy link
Member

sonora commented Sep 19, 2024

No rush, my vacation is coming up next, too!

@mikehgentry
Copy link

For what it's worth I use night mode for cycling sometimes (in the day!), higher contrast can make it easier to read in bright sunlight.

@sonora
Copy link
Member

sonora commented Sep 20, 2024

Thanks for the heads-up! So how would you rate the cyclepath and cycleway contrast on average, is it sufficient?

PS: We use the same or even a little less night contrast for 'tracks', which are also used by bicycle. So it seems that if we decided to change something, we probably should make more widespread adjustments...

@vshcherb vshcherb added the Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning label Sep 20, 2024
@mikehgentry
Copy link

I will test that properly at some point when the sun reappears (which could be a while! #British problems)

@sonora
Copy link
Member

sonora commented Sep 21, 2024

I have brightened the night cycleway night color by ten percentage points - perhaps that does the trick! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning
Projects
None yet
Development

No branches or pull requests

4 participants