Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the daemonset controller to understand upstream admission config format #19250

Open
deads2k opened this issue Apr 6, 2018 · 2 comments
Assignees
Labels
kind/delivery-blocker lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P1
Milestone

Comments

@deads2k
Copy link
Contributor

deads2k commented Apr 6, 2018

The daemonset controller patch that is optimizing the pods being created by preventing the creation of pods that it knows will fail. The "PodNodeSelector" (the upstream one) admission plugin has a config that doesn't seem to match the "normal" flow. We need to update the controller config parser to find the value.

It'll be in vendor/k8s.io/kubernetes/cmd/kube-controller-manager/app/patch_flags.go after #18989 lands.

@mfojtik @tnozicka @aveshagarwal @sjenning fyi

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2018
@tnozicka
Copy link
Contributor

tnozicka commented Jul 9, 2018

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/delivery-blocker lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P1
Projects
None yet
Development

No branches or pull requests

5 participants