Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Move "Accept Cookie" to Storage #122

Closed
2 of 4 tasks
elisei opened this issue Apr 28, 2022 · 4 comments
Closed
2 of 4 tasks

[ENHANCEMENT] Move "Accept Cookie" to Storage #122

elisei opened this issue Apr 28, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@elisei
Copy link
Contributor

elisei commented Apr 28, 2022

Description

The "acceptance of cookies" is currently in session, which creates unwanted behavior, customer returns to the site and even being logged in, or even with persistence of their cart, needs to accept cookies again.

Priority of the change:

  • High
  • Medium
  • Low

Which problem the feature would fix?
O comportamento para dos cookies

Describe the solution as simple as possible
Move the cookie to local storage.

Additional context
image
image

Contributing

  • Would you want to contribute and to be assigned to this enhancement?
@elisei elisei added the enhancement New feature or request label Apr 28, 2022
elisei added a commit to elisei/magento2-gdpr that referenced this issue Apr 28, 2022
@thomas-kl1
Copy link
Member

Hi @elisei

This comment might interest you: #9 (comment)
There's already a similar feature in Magento so we don't need the one provided by this module (as it only shows a disclosure and don't allow to consent to and configure stored cookies)

@elisei
Copy link
Contributor Author

elisei commented Apr 29, 2022

Hi @thomas-kl1

I believe that the topic you mention is not quite what I propose, maybe the pull clarifies it better:
elisei@f325aff

The main proposed changes are:

  • Set visible to false. It will only be displayed if there is no cookie.
  • Instead of setting the cookie to "session" I move it to local storage. This will make the once-dated authorization remain as authorized until the data is cleared. With this, the client returns to the site, after a period longer than the session, he is still authorized.

This last point aims to correct situations such as:

  • Customer comes back to the site, the session time for account cookies has not yet expired, but we still ask for his authorization to record cookies! o.O Hours if I have not yet authorized cookies how am I still logged in?

elisei added a commit to elisei/magento2-gdpr that referenced this issue Apr 29, 2022
@elisei
Copy link
Contributor Author

elisei commented Apr 29, 2022

PS. In Pull also add a check so that the popup is only visible if it is not a bot or lighthouse, thus avoiding loss in the CLS factor.

@thomas-kl1
Copy link
Member

@elisei feel free to open a pull request

thomas-kl1 added a commit that referenced this issue May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants