Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/prometheus] shouldn't resource_to_telemetry_conversion.enabled be true by default? #35286

Open
mathnogueira opened this issue Sep 18, 2024 · 2 comments

Comments

@mathnogueira
Copy link

Component(s)

exporter/prometheus, exporter/prometheusremotewrite

Describe the issue you're reporting

I was working on a local stack for retrieving metrics from Kubernetes and also receive metrics from our applications and publish them to our local Grafana. Everything was working fine but all metrics were strange because they had no labels (i.e. no attributes were sent to grafana).

After 4 days debugging the connections between our k8s scrapper collectors, our main collector, and our prometheus server, I discovered I was missing the resource_to_telemetry_conversion.enabled: true option in my prometheus exporter config.

#27839 was useful to discover I was missing that configuration. It's not the first time I had this problem, last year I had the same issue with the prometheusremovewrite exporter and I had forgotten about it. I was wondering why this flag is set as false as its default value. Couldn't this be set as true as this is crucial to have metrics working properly with prometheus?

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mathnogueira mathnogueira changed the title shouldn't resource_to_telemetry_conversion.enabled be true by default? [exporter/prometheus] shouldn't resource_to_telemetry_conversion.enabled be true by default? Sep 18, 2024
@dashpole
Copy link
Contributor

This is something we are considering, but have chosen not to do right now because resource can contain a huge number of attributes, which are often very long (e.g. process.command_args).

Instead, we provide a metric named target_info, which can be joined with your metrics to achieve similar behavior.

cc @gouthamve, since this is related to recent proposals around entities.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants