Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for deploying an app where the meteor app folder is a sub-folder of the git repo #19

Open
rbabayoff opened this issue Aug 1, 2013 · 7 comments

Comments

@rbabayoff
Copy link

No description provided.

@RobertLowe
Copy link

+1 because of things like phonegap

@llama
Copy link

llama commented Feb 14, 2014

This would work if you just deploy the subdirectory using git subtree push --prefix mySubDirectory heroku master.

If it gives trouble about being behind the remote, run git push heroku git subtree split --prefix mySubDirectory master:master -f

You wouldn't be able to use any files in your repo not included in your subdirectory.

@paralin
Copy link
Member

paralin commented Feb 14, 2014

+1 llama, but I could just search for a .meteor directory recursively.

@gsuess
Copy link

gsuess commented Aug 5, 2014

we have an admin app in the sub-directory admin and the front app in the sub-directory app. So I don't think llama's suggestion would work for us as it would break some symbolic links for packages that are shared across the two apps. Searching the meteor directory recursively is also a bad idea in that sense, because it would be ambiguous.

Having a environment variable in which the meteor root directory can be given would be preferable. That way we could deploy it once with that variable set to app and then once with it set to admin.

@bitomule
Copy link

I'm also using a sub directory for the app and have custom packages on root, this option is a must for me. Any way I can help?

@gsuess
Copy link

gsuess commented Aug 20, 2014

@bitomule ive created a fork that supports it at https://github.com/CulturalMe/heroku-buildpack-meteorite, however it doesn't use environment variables, because I couldn't get the detect script to read the those variables. So instead you have commit a file that contains the value of the sub-path to use. It's not ideal but it does the job. Another alternative would be to make the detect script accept anything.

Either way its hacky and not worth pull request so far.

@bitomule
Copy link

thanks @gsuess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants