Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Imprv] add functionality to update subnets to module ntnx_subnets #301

Open
bhati-pradeep opened this issue Oct 31, 2022 · 3 comments · May be fixed by #424
Open

[Imprv] add functionality to update subnets to module ntnx_subnets #301

bhati-pradeep opened this issue Oct 31, 2022 · 3 comments · May be fixed by #424
Assignees
@premkarat @alaa-bish @Gevorg-Khachatryan-97
Labels
enhancement New feature or request triage Tickets for triage

Comments

@bhati-pradeep
Copy link
Collaborator

bhati-pradeep commented Oct 31, 2022 •
edited
Loading

Describe the request
Add functionality to update subnets in ntnx_subnets. Identify such subnet components which can be updated and add functionality as per that.

Current behaviour
It only allows creation and delete

Expected behaviour
Should be able to update subnet

Refer docs: https://www.nutanix.dev/api_references/prism-central-v3/#/c4c4a9a81a449-update-a-existing-subnet
@bhati-pradeep bhati-pradeep added the enhancement New feature or request label Oct 31, 2022
@OpsCharlie
Copy link

I have the same issue.
When using name it creates a duplicate subnet

- name: VLAN subnet with IPAM, IP pools and DHCP
  nutanix.ncp.ntnx_subnets:
    name: "{{ ntnx_subnet.name }}"
    state: present
    vlan_subnet:
      vlan_id: "{{ ntnx_subnet.vlan_id }}"
      ....

When using subnet_uuid to "update" the subnet, it is mutual excluded:

- name: VLAN subnet with IPAM, IP pools and DHCP
  nutanix.ncp.ntnx_subnets:
    subnet_uuid "{{ ntnx_subnet.name }}"
    vlan_subnet:
      vlan_id: "{{ ntnx_subnet.vlan_id }}"
      ....

fatal: [localhost]: FAILED! => {"changed": false, "msg": "parameters are mutually exclusive: vlan_subnet|external_subnet|subnet_uuid|overlay_subnet"}

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Jan 17, 2023 •
edited
Loading

@OpsCharlie It is expected as subnet update is not yet supported. So for state="present" it will aways try to create a new subnet.

@bhati-pradeep bhati-pradeep added the triage Tickets for triage label Mar 3, 2023
@gdmjoho
Copy link

gdmjoho commented Oct 24, 2023

#424

@bhati-pradeep bhati-pradeep linked a pull request Oct 30, 2023 that will close this issue
Add update support to ntnx_subnets #424
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@premkarat premkarat

@alaa-bish alaa-bish

@Gevorg-Khachatryan-97 Gevorg-Khachatryan-97

Labels
enhancement New feature or request triage Tickets for triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add update support to ntnx_subnets gdm-allo/nutanix.ansible
6 participants
@premkarat @OpsCharlie @bhati-pradeep @alaa-bish @Gevorg-Khachatryan-97 @gdmjoho