From a4f2a99776d0cc7916dea7be40c60e155b05f17a Mon Sep 17 00:00:00 2001
From: Luka Trovic <luka@nextcloud.com>
Date: Wed, 21 Aug 2024 14:16:20 +0200
Subject: [PATCH 1/2] fix: 30 design issues

Signed-off-by: Luka Trovic <luka@nextcloud.com>
---
 src/App.vue                                      |  2 +-
 src/CardMoveDialog.vue                           |  1 -
 src/components/card/CardSidebar.vue              | 14 +++++++++++++-
 src/components/navigation/AppNavigationBoard.vue |  6 ++++++
 4 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index 2aa8d1868..350d8879b 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -192,7 +192,7 @@ export default {
 		min-width: 100%;
 		height: 100vh;
 		max-height: calc(100vh - 120px);
-		overflow: auto;
+		overflow: hidden;
 	}
 
 </style>
diff --git a/src/CardMoveDialog.vue b/src/CardMoveDialog.vue
index 26d2f4308..59a42a579 100644
--- a/src/CardMoveDialog.vue
+++ b/src/CardMoveDialog.vue
@@ -92,7 +92,6 @@ export default {
 
 <style lang="scss" scoped>
 .modal__content {
-	width: 25vw;
 	min-width: 250px;
 	min-height: 120px;
 	margin: 20px 20px 100px 20px;
diff --git a/src/components/card/CardSidebar.vue b/src/components/card/CardSidebar.vue
index be06e4edb..10f06f708 100644
--- a/src/components/card/CardSidebar.vue
+++ b/src/components/card/CardSidebar.vue
@@ -209,6 +209,10 @@ section.app-sidebar__tab--active {
 	height: 100%;
 }
 
+.modal-container {
+	overflow: hidden;
+}
+
 // FIXME: Obivously we should at some point not randomly reuse the sidebar component
 // since this is not oficially supported
 .modal__card .app-sidebar {
@@ -222,10 +226,18 @@ section.app-sidebar__tab--active {
 	max-width: calc(100% - #{$modal-padding * 2});
 	padding: 0 14px;
 	height: 97%;
-	overflow: initial;
+	overflow: hidden !important;
 	user-select: text;
 	-webkit-user-select: text;
 
+	.app-sidebar-header__mainname-container {
+		padding-top: calc(var(--default-grid-baseline, 4px) * 2);
+	}
+
+	.app-sidebar-tabs {
+		max-height: 90%;
+	}
+
 	// FIXME: test
 	&:deep {
 		.app-sidebar-header {
diff --git a/src/components/navigation/AppNavigationBoard.vue b/src/components/navigation/AppNavigationBoard.vue
index 088779428..addb71bac 100644
--- a/src/components/navigation/AppNavigationBoard.vue
+++ b/src/components/navigation/AppNavigationBoard.vue
@@ -350,4 +350,10 @@ export default {
 	.forced-active {
 		box-shadow: inset 4px 0 var(--color-primary-element);
 	}
+
+	:deep(.active) {
+		.material-design-icon svg {
+			fill: var(--color-primary-element-text);
+		}
+	}
 </style>

From fb54b8126ab811973d5b3d088bb1c45695c9189c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Thu, 29 Aug 2024 11:33:16 +0200
Subject: [PATCH 2/2] fix: Avoid duplicate scrollbars
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 src/App.vue                         | 3 +--
 src/components/card/CardSidebar.vue | 5 +++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index 350d8879b..a6274e76b 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -190,8 +190,7 @@ export default {
 	.modal__card {
 		width: 100%;
 		min-width: 100%;
-		height: 100vh;
-		max-height: calc(100vh - 120px);
+		height: calc(100% - 20px);
 		overflow: hidden;
 	}
 
diff --git a/src/components/card/CardSidebar.vue b/src/components/card/CardSidebar.vue
index 10f06f708..41fd9dea8 100644
--- a/src/components/card/CardSidebar.vue
+++ b/src/components/card/CardSidebar.vue
@@ -238,6 +238,11 @@ section.app-sidebar__tab--active {
 		max-height: 90%;
 	}
 
+	.app-sidebar__tab {
+		min-height: calc(100% - 20px);
+		max-height: calc(100% - 20px);
+	}
+
 	// FIXME: test
 	&:deep {
 		.app-sidebar-header {