Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link sweep for #17910 #17920

Closed
wants to merge 3 commits into from
Closed

Conversation

austin-schaefer
Copy link
Contributor

@austin-schaefer austin-schaefer commented Jul 8, 2024

Fixes #17910

I left off on this line:

[✖] https://api.newrelic.com/graphiql → Status: 401

I see four basic categories of links:

  1. Actual broken links to fix
  2. Tricky ones
  3. False positives in code blocks
  4. URLs that we need to add to ignore list

Notes

Notes on tricky ones:

  • http://code.activestate.com/pypm/newrelic/ > This seems to be a dead tool, issue created in NR-288979 to delete this entire category of docs
  • http://curl.haxx.se/libcurl/php/ > libcurl also appears to be outdated, checking with PHP agent team
  • Rightscale-related URLs: To be deleted, see NR-289019

False positives in code blocks I'm discussing with eng:

  • http://example_ip:3000/exchange
  • http://my-uri.com/

URLs we should add to ignore list:

  • http://localhost:8000/
  • https://api.nerdsletter.net/cancellations

Also talk to eng: We should probably just not scan release notes at all

Copy link

github-actions bot commented Jul 8, 2024

Hi @austin-schaefer 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 3098f20
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/668c2647d3563900084f8e49
😎 Deploy Preview https://deploy-preview-17920--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@austin-schaefer austin-schaefer marked this pull request as draft July 8, 2024 21:12
@LizBaker
Copy link
Contributor

LizBaker commented Jul 8, 2024

%22 is a " character. looks like it happened in a couple release notes, e.g. [#1972](https":"//github.com/newrelic/newrelic-dotnet-agent/issues/1972)

@austin-schaefer austin-schaefer changed the title chore(sweep): External broken links Broken link sweep for #17910 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link(s) found
3 participants