You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This section contains basic information regarding the change request.
1.1 Change Request Information
__
__
Requested By
Kevin Leyow, Modusbox
Change Request Status
In review ☒ / Approved ☐ / Rejected ☐
Approved/Rejected Date
2. Problem Description
___
2.1 Background
The OpenApi definitions of v1.0 and v1.1 of the FSPIOP Specification defines components that are not used.
2.2 Current Behaviour
Current definition has unused components which are redundant or needs updating. Using bundling libraries can lead to unwanted behaviour when rending out a microservice interface.
2.3 Requested Behaviour
References are updated. Redundant components are removed.
@kleyow - don't think this is an issue with the API Definition as such; more with the tooling we use - Swagger/Open API.. Its possible that we simply leave these out of the swagger while referencing those items that fall under this type (use same regular expressions, etc) to the basic types (in the description text) in the API Definition doc.
At the time of drafting, these were included knowing that these basic types are not going to be referenced as-is.
@elnyry-sam-k Sorry Sam. I'm really bad at using proper nomenclature.
I have no issue with the API definition. Yes this ticket is more to fix the tooling and the OpenAPI definition files that are found in this repo. Since I use them as the accurate representation of the API definition which is turned into the OpenApi definition.
Is it not possible to just fix the references in the Openapi definition.
Open API for FSP Interoperability - Change Request
Table of Contents
1. Preface
___This section contains basic information regarding the change request.
1.1 Change Request Information
2. Problem Description
___2.1 Background
The OpenApi definitions of v1.0 and v1.1 of the FSPIOP Specification defines components that are not used.
2.2 Current Behaviour
Current definition has unused components which are redundant or needs updating. Using bundling libraries can lead to unwanted behaviour when rending out a microservice interface.
2.3 Requested Behaviour
References are updated. Redundant components are removed.
3. Proposed Solution Options
___Update references in v1.0 and v1.1 document sets.
https://github.com/mojaloop/mojaloop-specification/blob/master/fspiop-api/documents/v1.0-document-set/fspiop-rest-v1.0-OpenAPI-implementation_openapi3.yaml
https://github.com/mojaloop/mojaloop-specification/blob/master/fspiop-api/documents/v1.1-document-set/fspiop-v1.1-openapi3.yaml
List of defined but unused components
v1.0
v1.1
The text was updated successfully, but these errors were encountered: