Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Request: updated query params, filters for settlement resources #105

Open
partiallyordered opened this issue Nov 5, 2021 · 2 comments
Assignees
Labels
settlement-api-change-request A change request made to the Settlement API

Comments

@partiallyordered
Copy link

partiallyordered commented Nov 5, 2021

Open API for FSP Interoperability - Change Request

Table of Contents

1. Preface

___

This section contains basic information regarding the change request.

1.1 Change Request Information

| Requested By | Matt Kingston |
| Change Request Status | In review ☒ / Approved ☐ / Rejected ☐ |
| Approved/Rejected Date | |

1.2 Document Version Information

Version Date Author Change Description
1.0 2021-11-05 Matt Kingston Initial version. Sent out for review.

2. Problem Description

___

2.1 Background

When retrieving settlement information, it is desirable to include multiple parameters in filters in order to more efficiently retrieve settlements.

2.2 Current Behaviour

In order to retrieve settlements containing multiple accounts, participants, states, or windows, a user must make multiple requests. Example:

GET /v2/settlements?accountId=1
GET /v2/settlements?accountId=2
GET /v2/settlements?accountId=3

2.3 Requested Behaviour

GET /v2/settlements?accountId=1,2,3

Should return the aggregated results that would have been returned from the current behaviour, when making three separate requests. Similarly with other query parameters.

3. Proposed Solution Options

mojaloop/central-settlement#372

@elnyry-sam-k elnyry-sam-k changed the title Change Request: <Change Request Title> Change Request: updated query params, filters for settlement resources Nov 5, 2021
@elnyry-sam-k elnyry-sam-k added the settlement-api-change-request A change request made to the Settlement API label Nov 5, 2021
@elnyry-sam-k
Copy link
Member

@partiallyordered thanks for the CR. @mdebarros hoping you can add this to the Agenda for the next week SIG meeting..

@mdebarros
Copy link
Member

mdebarros commented Nov 10, 2021

Attendees of the meeting on 2021-11-10 @ 14h00 GMT:

Quorum has accepted this change and the proposed changes to the API Interface Spec for the Settlement's API by the following members:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
settlement-api-change-request A change request made to the Settlement API
Projects
None yet
Development

No branches or pull requests

6 participants