Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes notification alignment #3522

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

HeleenSG
Copy link
Contributor

@HeleenSG HeleenSG commented Sep 12, 2024

Changes

  • Fixes alignment issue in inline notifications.

Issue link

Alignment issue within notifications:
Screenshot 2024-09-12 at 11 54 18

Please add the link to the issue after "Closes".

Closes #3502

Demo

Inline (p, span etc)
Screenshot 2024-09-11 at 17 56 18

Block notifications:
Screenshot 2024-09-11 at 17 58 12

QA notes

  • Please check in multiple places if all types are working correctly.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@HeleenSG HeleenSG self-assigned this Sep 12, 2024
@HeleenSG HeleenSG marked this pull request as ready for review September 12, 2024 10:00
@HeleenSG HeleenSG requested a review from a team as a code owner September 12, 2024 10:00
@underdarknl
Copy link
Contributor

Code looks good to me.

@stephanie0x00 stephanie0x00 added the 😸 Review/QA feedback Review/QA feedback provided label Sep 16, 2024
@stephanie0x00
Copy link
Contributor

A few unexpected situations were found:

  • Clicking the Add indemnification button on the Settings page
  • In the onboarding the confirmation message is smaller. This also happens when adding a new organisation.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend 😸 Review/QA feedback Review/QA feedback provided
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Reports - Warning message layout as columns
3 participants