Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows Terminal - Settings - Color Schemes]: 'Add new' button's text is getting truncated and not visible properly at 200% text scaling. #17897

Closed
SaurabhNew opened this issue Sep 11, 2024 · 3 comments · Fixed by #17910
Closed

[Windows Terminal - Settings - Color Schemes]: 'Add new' button's text is getting truncated and not visible properly at 200% text scaling. #17897

SaurabhNew opened this issue Sep 11, 2024 · 3 comments · Fixed by #17910
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@SaurabhNew
Copy link

Windows Terminal version

1.22.2362.0

Windows build number

27695.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 27695.1000)
App: Windows Terminal Preview

Steps to reproduce

Pre-requisite:
Settings>Display>Display Resolution (1680*1050)>set scaling to 100%>Increase the text slider to 200% >Apply>Reopen the application.

Repro steps:

  1. Open the 'windows terminal' application.
  2. Follow the above-mentioned pre-requisite step.
  3. Now open 'Settings'.
  4. Navigate to the 'Color Schemes' tab and activate it.
  5. Navigate to the 'Add new' button.
  6. Observe the issue.

User experience:
Users with low vision rely on zooming features for navigation will feel difficulty in understanding the button's name, if name gets truncated at 200% zoom.

WCAG Reference Link:
https://www.w3.org/WAI/WCAG21/Understanding/resize-text

Attachment:
MAS1.4.4 - Add new button's text is not visble properly at 200% text scaling.zip

Expected Behavior

'Add new' button's text should be properly visible at 200% text scaling.

Actual Behavior

'Add new' button's text is getting truncated and not visible properly at 200% text scaling.

Note:
Same issue repro for 'Foreground colors' & 'Set as default' button. (Navigation Path: Windows Terminal> Settings> Color schemes> Add new> 'Foreground colors' & 'Set as default button').
@SaurabhNew SaurabhNew added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 11, 2024
@similar-issues-ai Similar Issues AI
Copy link

We've found some similar issues:

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

@similar-issues-ai similar-issues-ai bot mentioned this issue Sep 11, 2024
Closed
@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Sep 11, 2024
@carlos-zamora carlos-zamora added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 11, 2024
@carlos-zamora
Copy link
Member

@SaurabhNew is there an associated severity rating for this issue?

@carlos-zamora carlos-zamora mentioned this issue Sep 11, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Sep 11, 2024
@Priyanka-Chauhan123 Priyanka-Chauhan123 added HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev2 Accessibility tracking labels Sep 12, 2024
@SaurabhNew
Copy link
Author

SaurabhNew commented Sep 12, 2024 •
edited
Loading

@carlos-zamora,
Tags are updated now.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 17, 2024
DHowett pushed a commit that referenced this issue Sep 17, 2024
@carlos-zamora @DHowett
Fix text scaling issues in settings UI (#17910)
84a33af 
## Summary of the Pull Request
Fixes some issues with truncated text in the settings UI when 200% text
scaling is applied.

For #17897, a minimum height was applied instead of a plain "height".
This ensures that the desired height is applied in general, but under
200% text scaling, we are allowed to grow past that, thus preventing the
truncation of the text.

For #17898, flyouts have a scroll viewer inside them by default. We
actually don't want the scroll viewer because that means the text will
appear "truncated" when in reality, the user is expected to notice the
small scrollbar and scroll horizontally (why that's the default, I will
never know). This PR introduces a new style that can be applied to these
flyouts to cause text wrapping instead of horizontal scrolling. Looked
through the app for any instances where this happens.

For #12006, simply changing the column width from a static value to
"auto" fixes the issue. Frankly, we care more about the text appearing
as a whole (and as whole words). The name of the actions wrap properly
anyways.

Closes #17897
Closes #17898
Closes #12006

(cherry picked from commit a7e47b7)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTEfj0
Service-Version: 1.21
DHowett pushed a commit that referenced this issue Sep 17, 2024
@carlos-zamora @DHowett
Fix text scaling issues in settings UI (#17910)
44315b4 
## Summary of the Pull Request
Fixes some issues with truncated text in the settings UI when 200% text
scaling is applied.

For #17897, a minimum height was applied instead of a plain "height".
This ensures that the desired height is applied in general, but under
200% text scaling, we are allowed to grow past that, thus preventing the
truncation of the text.

For #17898, flyouts have a scroll viewer inside them by default. We
actually don't want the scroll viewer because that means the text will
appear "truncated" when in reality, the user is expected to notice the
small scrollbar and scroll horizontally (why that's the default, I will
never know). This PR introduces a new style that can be applied to these
flyouts to cause text wrapping instead of horizontal scrolling. Looked
through the app for any instances where this happens.

For #12006, simply changing the column width from a static value to
"auto" fixes the issue. Frankly, we care more about the text appearing
as a whole (and as whole words). The name of the actions wrap properly
anyways.

Closes #17897
Closes #17898
Closes #12006

(cherry picked from commit a7e47b7)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTEfj8
Service-Version: 1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

Successfully merging a pull request may close this issue.

Fix text scaling issues in settings UI microsoft/terminal
3 participants
@carlos-zamora @Priyanka-Chauhan123 @SaurabhNew