Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT compatibility, and move to System.Text.Json #594

Open
HalvorNygaard opened this issue Mar 5, 2024 · 5 comments
Open

AOT compatibility, and move to System.Text.Json #594

HalvorNygaard opened this issue Mar 5, 2024 · 5 comments

Comments

@HalvorNygaard
Copy link

Is there a plan to move from Newtonsoft.Json to System.Text.Json? Will this make RulesEngine AOT compatible, or is there still other logic relying on reflection? Is there ways to use RulesEngine with AOT today?

@madhon
Copy link
Contributor

madhon commented Apr 24, 2024

any comments @abbasc52 ?

@asulwer
Copy link

asulwer commented Jun 21, 2024

System.Text.Json is restrictive, has lots of checks in that. lots of work for no real benefit

Migrate from Newtonsoft.Json

@HalvorNygaard
Copy link
Author

Well the question was concerning the AOT compatibilty, as Microsoft changed up a lot of internals of ASP.NET to make it AOT compatible, I would guess within a year or two you will have to use aot compilation to get the most out of it. So the benefit would to also be able to use it it projects built for AOT compilation.

Just came across the issue when i tried to compile a .NET app AOT, haven't tested out the proposed fix myself, so I don't know what the implications of swapping the json serializer are.

@asulwer
Copy link

asulwer commented Jun 24, 2024

swapping would mean reinventing code that Newtonsoft.Json provides and System.Text.Json does not. i am not saying its off the table, maybe a future lite version. regardless this project is dead and my fork is not

@RenanCarlosPereira
Copy link

@madhon please check out this PR:
I just migrated it, and everything looks fine 😎

asulwer#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants