Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public vs. docroot #6

Open
dasjo opened this issue Sep 25, 2021 · 8 comments
Open

Public vs. docroot #6

dasjo opened this issue Sep 25, 2021 · 8 comments
Assignees

Comments

@dasjo
Copy link

dasjo commented Sep 25, 2021

hi there,

i tried getting started with the template, following instructions from
https://www.mautic.org/blog/developer/managing-mautic-with-composer

i ran the create command successfully:
composer create-project mautic/recommended-project:4.x-dev some-dir --no-interaction

one thing that irritated me is that the documentation mentions "public" being used as a folder while the script puts it into "docroot". this doesn't seem to cause any problems but might be worth aligning to avoid confusion

best,
josef


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@RCheesley
Copy link
Sponsor Member

Thanks for flagging this up!

@nickveenhof one for you, might need to update the documentation?

@nickveenhof
Copy link
Contributor

What is generally the most accepted name these days? Public? Web? Docroot?

@davidspiola
Copy link

I would vote for "Web" :-)

@Moongazer
Copy link

Moongazer commented May 6, 2023

Most projects I've seen using public/, also this is the default when using DDEV. That's why I'd vote stongly for public/.

Edit:
Another good reason for NOT using web/ or docroot/ is, that these folders-names are often used by shared-hosting providers for the "root" of a shared-host account. Using public/ as sub-folder where the domain is pointing to makes most sense (instead of pointing to web/web/ or docroot/docroot/ in such cases):

/var/www/customer-123456/[web|docroot]/ (shared-hosting root)
  my-backups/
  bin/
  public/ (here's where the domain points to)
  vendor/

@mabumusa1
Copy link
Member

Most projects I've seen using public/, also this is the default when using DDEV. That's why I'd vote stongly for public/.

Edit:
Another good reason for NOT using web/ or docroot/ is, that these folders-names are often used by shared-hosting providers for the "root" of a shared-host account. Using public/ as sub-folder where the domain is pointing to makes most sense (instead of pointing to web/web/ or docroot/docroot/ in such cases):

/var/www/customer-123456/[web|docroot]/ (shared-hosting root)
  my-backups/
  bin/
  public/ (here's where the domain points to)
  vendor/

@Moongazer would like to make a PR for this, there is another PR that is very close to get merged is getting Mautic closer to symfony standard folder structure

@Moongazer
Copy link

I can try if I find some spare time. But before I start working on a PR:

Does everyone agree that we use public/ as default for every future Mautic setup via recommended-project? I mean, is this a fixed decision already?

@mabumusa1
Copy link
Member

I can try if I find some spare time. But before I start working on a PR:

Does everyone agree that we use public/ as default for every future Mautic setup via recommended-project? I mean, is this a fixed decision already?

We did not discuss it explicitly in the community, but I think many of us agree that we need to be closer to how Symfony is structured, check the discussion here

mautic/mautic#12206 (review)

If you are on slack, please join us in product channel, I will post about this topic today

@tomekkowalczyk
Copy link

public as default for every future Mautic setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants