Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix from_name and from_email labels #14055

Draft
wants to merge 1 commit into
base: 5.1
Choose a base branch
from
Draft

Fix from_name and from_email labels #14055

wants to merge 1 commit into from

Conversation

mauricoder
Copy link

Q A
Bug fix? (use the a.b branch) 🟢
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed Fixes #14040

Description

When sending a Quick Email to a contact, the labels for the first two input boxes, for lead_quickemail[fromaddress] and lead_quickemail[from] are confusing. They are labeled "From Address" (where it should say From Name), and "From" where it should say "From Address".

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Go to Contacts
  3. Open a contact
  4. Click the "Send Email" button
  5. In the form opened the labels for the first two fields are wrong. They should be From name (not From address) and From address (not From)

@mauricoder mauricoder mentioned this pull request Aug 15, 2024
Open
1 task
@mauricoder mauricoder added the WIP PR's that are not ready for review and are currently in progress label Aug 16, 2024
@mauricoder
Copy link
Author

I misunderstood the bug, I'll fix this PR to fix whole bug.

@RCheesley RCheesley linked an issue Aug 19, 2024 that may be closed by this pull request
Custom e-mail reply-to address uses default sender address when field is left blank #14040
Open
1 task
@RCheesley RCheesley added email Anything related to email T1 Low difficulty to fix (issue) or test (PR) labels Aug 19, 2024
@RCheesley RCheesley marked this pull request as draft August 30, 2024 16:21
@RCheesley
Copy link
Sponsor Member

Hi @mauricoder I've set this to draft while you work on it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
email Anything related to email T1 Low difficulty to fix (issue) or test (PR) WIP PR's that are not ready for review and are currently in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom e-mail reply-to address uses default sender address when field is left blank
2 participants
@mauricoder @RCheesley