Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow https for Apprise #236

Open
schklom opened this issue Jun 10, 2023 · 2 comments
Open

Allow https for Apprise #236

schklom opened this issue Jun 10, 2023 · 2 comments

Comments

@schklom
Copy link
Contributor

schklom commented Jun 10, 2023

I suggest changing

return got.post(`http://${options.host}/notify/`, {

to

    return got.post(`${options.url}/notify/`, {

and

"host": "apprise:8080",

to

      "url": "http://apprise:8080",

This would let users specify http or https without being overly complicated.

@marklagendijk
Copy link
Owner

The intended use is to use Apprise as a sibling container.
Https would only be needed in a situation where Apprise is on a different host and behind a proxy setup that adds HTTPS.

@schklom
Copy link
Contributor Author

schklom commented Jun 10, 2023

I use Apprise for other services, not only this one.
For security, I try to separate containers and make connections via my reverse-proxy when possible, just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants