-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facebook SDK for iOS v4.39.0 #329
Comments
We are encountering the same problem with this library |
i think this is urgent issue |
for android i could solve it by doing this:
|
i think the sdk should be configurable same as |
Can somebody please share some steps what to do for both projects to upgrade SDK? |
You can follow this branch: https://github.com/rollstudio/react-native-facebook-login/tree/feature/update-facebook-sdk Fork the repo and: For Android:
For iOS:
I did this for a project and it seems to work well, do not use my repo as a dependency because I didn't had an occasion to clean it up and also the android dependency is a bit of a mess because I was testing a few things (my project had a override of buildToolsVersion but I totally forgot and started to try various buildToolsVersion). Worth a shot I guess, I haven't tested well enough to say it's the best solution to upgrade but it should work. If it's stable I will try to clean up my fork and do a PR. About the version, I know the email says to upgrade to 4.39 but I think 4.38 should be fine because it will use the version 3.x of the Graph API anyway. |
Today, I have the notification from Facebook as below:
"As a result, there is a risk that your app will no longer function if you don't upgrade to Facebook SDK for Android v4.39.0 and Facebook SDK for iOS v4.39.0.
As an admin of this app, please upgrade to the latest SDK as soon as possible to ensure your app's continued performance and to take advantage of new features."
I install the lastest version but the FacebookSDK still the old version. Please check the source FacebookSDK from "../node_modules/react-native/FacebookSDK/FBSDKCoreKit.framework/Headers/FBSDKCoreKit.h"
#define FBSDK_VERSION_STRING @"4.7.0"
#define FBSDK_TARGET_PLATFORM_VERSION @"v2.5"
I tried add manual the lastest version to Xcode but the source is not working. Please help me. Thanks
The text was updated successfully, but these errors were encountered: