Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook SDK for iOS v4.39.0 #329

Open
namhdwebsoft opened this issue Dec 11, 2018 · 6 comments
Open

Facebook SDK for iOS v4.39.0 #329

namhdwebsoft opened this issue Dec 11, 2018 · 6 comments

Comments

@namhdwebsoft
Copy link

Today, I have the notification from Facebook as below:
"As a result, there is a risk that your app will no longer function if you don't upgrade to Facebook SDK for Android v4.39.0 and Facebook SDK for iOS v4.39.0.
As an admin of this app, please upgrade to the latest SDK as soon as possible to ensure your app's continued performance and to take advantage of new features."

I install the lastest version but the FacebookSDK still the old version. Please check the source FacebookSDK from "../node_modules/react-native/FacebookSDK/FBSDKCoreKit.framework/Headers/FBSDKCoreKit.h"

#define FBSDK_VERSION_STRING @"4.7.0"
#define FBSDK_TARGET_PLATFORM_VERSION @"v2.5"

I tried add manual the lastest version to Xcode but the source is not working. Please help me. Thanks

@rogierslag
Copy link

We are encountering the same problem with this library

@digital-flowers
Copy link

i think this is urgent issue

@digital-flowers
Copy link

for android i could solve it by doing this:

allprojects {
  repositories {
    google()
    jcenter()
    maven {
      url "https://jitpack.io"
    }
    maven {
      url "$rootDir/../node_modules/react-native/android"
    }
    configurations.all {
      resolutionStrategy {
        force "com.facebook.android:facebook-android-sdk:4.39.0"
      }
    }
  }
}

@digital-flowers
Copy link

i think the sdk should be configurable same as react-native-accountkit module, look here: https://github.com/underscopeio/react-native-facebook-account-kit/blob/master/android/build.gradle

@vvusts
Copy link

vvusts commented Dec 13, 2018

Can somebody please share some steps what to do for both projects to upgrade SDK?

@marcoacierno
Copy link

marcoacierno commented Dec 14, 2018

@vvusts

You can follow this branch: https://github.com/rollstudio/react-native-facebook-login/tree/feature/update-facebook-sdk

Fork the repo and:

For Android:

  • Open android/build.gradle
  • Update the compile line of the SDK to com.facebook.android:facebook-android-sdk:4.39.0
  • Remove the exclude group bolts-applinks and bolts-android

For iOS:

  • Download the SDK from the Facebook SDK website: https://developers.facebook.com/docs/ios/downloads/ I used 4.38 because 4.39 introduced a bug where the login does not work anymore
  • Replace FBSDKCoreKit.framework, FBSDKLoginKit.framework, FBSDKShareKit.framework
  • Copy Bolts.framework there, without it I had a white screen after launching the app, probably due to a missing dependency, due to my problem I couldn't debug well
  • Link Bolts.framework

I did this for a project and it seems to work well, do not use my repo as a dependency because I didn't had an occasion to clean it up and also the android dependency is a bit of a mess because I was testing a few things (my project had a override of buildToolsVersion but I totally forgot and started to try various buildToolsVersion).

Worth a shot I guess, I haven't tested well enough to say it's the best solution to upgrade but it should work. If it's stable I will try to clean up my fork and do a PR.

About the version, I know the email says to upgrade to 4.39 but I think 4.38 should be fine because it will use the version 3.x of the Graph API anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants