Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview is not expanded on applying bookmark if the same rowIndex preview was expanded #1770

Open
sivaschenko opened this issue Aug 19, 2020 · 1 comment
Open

Preview is not expanded on applying bookmark if the same rowIndex preview was expanded #1770

sivaschenko opened this issue Aug 19, 2020 · 1 comment
Labels
Complex Issue: Confirmed Priority: P4 Fixing can be deferred as a logical part of more important work Progress: ready for dev Severity: S4 A minor problem, annoyance, or technical issue with minimal impact

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Aug 19, 2020 •
edited
Loading

Preconditions (*)

Install, configure and enable New Media Gallery and Adobe

Steps to reproduce (*)

  1. Login to Admin Panel
  2. Go to Content -> Media Gallery
  3. Click "Search Adobe Stock" to open adobe stock image grid
  4. Click on second image in grid to open preview for it
  5. Save the view in a bookmark
  6. Go to second page of the grid
  7. Click on second image in grid to open preview for it
  8. Click on the bookmark saved on step 5

Expected result (*)

The bookmarked grid view is restored (1st page, 2nd image preview opened)

Actual result (*)

The bookmarked grid view is restored, however the preview is not expanded
@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko added Severity: S4 A minor problem, annoyance, or technical issue with minimal impact and removed Progress: ready for grooming labels Aug 19, 2020
@sivaschenko sivaschenko added the Priority: P4 Fixing can be deferred as a logical part of more important work label Aug 19, 2020
@sivaschenko sivaschenko added this to the 2.1.1 milestone Aug 25, 2020
@joweecaquicla joweecaquicla self-assigned this Aug 28, 2020
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Sep 1, 2020
magento/adobe-stock-integration#1770: Preview is not expanded on appl…
867c4a7 
…ying bookmark if the same rowIndex preview was expanded - initial fix
@joweecaquicla joweecaquicla mentioned this issue Sep 1, 2020
Closed
4 tasks
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Sep 18, 2020
magento/adobe-stock-integration#1770: Preview is not expanded on appl…
0f9f9f9 
…ying bookmark if the same rowIndex preview was expanded - modified image-preview.js
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Sep 18, 2020
magento#1770: Preview is not expanded on applying bookmark if the sam…
40b6f23 
…e rowIndex preview was expanded - added bookmarksprovider to asi listing ui component
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Sep 18, 2020
Revert "magento#1770: Preview is not expanded on applying bookmark if…
797c74a 
… the same rowIndex preview was expanded - added bookmarksprovider to asi listing ui component"

This reverts commit 40b6f23
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Sep 18, 2020
magento#1770: Preview is not expanded on applying bookmark if the sam…
7e1aa91 
…e rowIndex preview was expanded - added bookmarksprovider to asi listing ui component
@joweecaquicla joweecaquicla mentioned this issue Sep 18, 2020
Closed
@joweecaquicla joweecaquicla linked a pull request Sep 18, 2020 that will close this issue
[WIP] #1770: Preview is not expanded on applying bookmark if the same rowIndex preview was expanded #1842
Closed
@sivaschenko sivaschenko removed this from the 2.1.1 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complex Issue: Confirmed Priority: P4 Fixing can be deferred as a logical part of more important work Progress: ready for dev Severity: S4 A minor problem, annoyance, or technical issue with minimal impact
Projects
None yet
Milestone
No milestone
3 participants
@sivaschenko @Nazar65 @joweecaquicla